You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I built this PR locally for my native architecture, (x86_64)
Note: The package builds, installs and runs fine with the template as proposed, but the readme states the following:
"Build options and their dependencies
This is the list of configurable packages and what they provide in nomacs. To ensure a feature is included/excluded set the cmake option for that feature. By default, all features are enabled if the dependencies are found when running cmake**.
The following Qt components are necessary: Core, Concurrent, Network, PrintSupport, SVG, Widgets, Core5Compat."
Of these dependencies only qt6-svg-devel was already present from previous versions. I added qt6-qt5compat-devel because the build would otherwise fail.
The packages qt6-core qt6-concurrent qt6-network qt6-printsupport qt6-widgets aren't necessary for building without error messages.
But as they are explicitly mentioned, I wonder if I should still add them. I wouldn't know, though, where to add them - to makedepends, hostmakedepends or even depends?
Another question would be the added -DENABLE_QUAZIP=1.
I did a build test with the previous version and during checks it said that quazip was enabled. Without any changes to the template in that regard for the new version, it would say that quazip was not included. So, I added the argument. I also did a test install with both options. With the added argument, the install would also install quazip-qt6, without the argument, it would not. I'm not sure if nomacs would be able to use the qt5 version of quazip that the previous version depended on. The qt5compat dependency might allow for that - or not, I don't know. So, the question would be if the added argument is needed or if it would be incompatible with the pre-existing argument -DUSE_SYSTEM_QUAZIP=1.
I tried cross-compiling and "native-compiling" for aarch64.
After adding bzip2-devel to hostmakedepends it almost worked...
Here are my test results:
cross-compile on x86_64:
Variant 1:
./xbps-src -a aarch64 pkg nomacs
error message after almost finishing building:
/usr/lib/gcc/aarch64-linux-gnu/14.2.1/../../../../aarch64-linux-gnu/bin/ld: /usr/lib64/libquazip1-qt6.so.1.4: error adding symbols: file in wrong format
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
Variant 2:
./xbps-src -A aarch64 pkg nomacs
error message immediately after executing the command:
ERROR Failed to execute command /void-packages/xbps-src (Exec format error)
compiling on aarch64 (rpi4):
./xbps-src pkg nomacs
error message at the end of the config test:
ninja: error: '/usr/aarch64-linux-gnu/usr/lib/libbz2.so', needed by 'libnomacsCore.so.3.22.0', missing and no known rule to make it
This one is especially annoying, because the allegedly missing file is in /usr/lib/. Not sure why the process thinks there should be a directory /usr/aarch64-linux-gnu/usr/lib/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Note: The package builds, installs and runs fine with the template as proposed, but the readme states the following:
"Build options and their dependencies
This is the list of configurable packages and what they provide in nomacs. To ensure a feature is included/excluded set the cmake option for that feature. By default, all features are enabled if the dependencies are found when running cmake**.
The following Qt components are necessary:
Core, Concurrent, Network, PrintSupport, SVG, Widgets, Core5Compat."Of these dependencies only
qt6-svg-develwas already present from previous versions. I addedqt6-qt5compat-develbecause the build would otherwise fail.The packages
qt6-core qt6-concurrent qt6-network qt6-printsupport qt6-widgetsaren't necessary for building without error messages.But as they are explicitly mentioned, I wonder if I should still add them. I wouldn't know, though, where to add them - to
makedepends,hostmakedependsor evendepends?Another question would be the added
-DENABLE_QUAZIP=1.I did a build test with the previous version and during checks it said that quazip was enabled. Without any changes to the template in that regard for the new version, it would say that quazip was not included. So, I added the argument. I also did a test install with both options. With the added argument, the install would also install quazip-qt6, without the argument, it would not. I'm not sure if nomacs would be able to use the qt5 version of quazip that the previous version depended on. The qt5compat dependency might allow for that - or not, I don't know. So, the question would be if the added argument is needed or if it would be incompatible with the pre-existing argument
-DUSE_SYSTEM_QUAZIP=1.